Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isloopback returns true incorrectly #765

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

james-d-elliott
Copy link
Contributor

@james-d-elliott james-d-elliott commented Aug 19, 2023

This adds a test case proving and subsequently fixes #750

Related Issue or Design Document

#750

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

This adds a test case proving ory#750
This fixes an issue where isLookbackAddress returns true incorrectly.
@aeneasr aeneasr merged commit 44fd2cc into ory:master Aug 22, 2023
@james-d-elliott james-d-elliott deleted the fix-isloopback-invalid-ip branch August 22, 2023 10:02
shipperizer pushed a commit to shipperizer/fosite that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

authorize_helper.isLoopbackAddress has flaws
3 participants